Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags

Поиск

Список

Период

Сортировка

От	Haribabu Kommi
Тема	Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags
Дата	22 марта 2017 г. 06:42:03
Msg-id	CAJrrPGcsDC-oy1AhqH0JkXYa0Z2AgbuXzHPpByLoBGMxfOZMEQ@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags ("Seki, Eiji" <seki.eiji@jp.fujitsu.com>)
Ответы	Re: [HACKERS] Proposal: GetOldestXminExtend for ignoring arbitraryvacuum flags
Список	pgsql-hackers

On Wed, Mar 22, 2017 at 1:53 PM, Seki, Eiji <seki.eiji@jp.fujitsu.com> wrote:

Thank you for your review, again.

I think your proposals are better, so I reflected them.

Thanks for the updated patch. Patch looks good to me.

I marked it as "ready for committer".

While reviewing this patch, I found that PGXACT->vacuumFlags

variable name needs a rename because with the addition of

PROC_IN_LOGICAL_DECODING flag "vacuumFlags" doesn't

only use it for vacuum operation. I feel this variable can be renamed

as just "flags", but anyway that is a different patch.

Regards,

Hari Babu

Fujitsu Australia

В списке pgsql-hackers по дате отправления: