Re: Synchronizing slots from primary to standby

On Tue, Feb 6, 2024 at 12:25 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi,

> That said, I still think the commit message needs some re-wording, what about?
>
> =====
> If a logical slot on the primary is valid but is invalidated on the standby,
> then that slot is dropped and can be recreated on the standby in next
> pg_sync_replication_slots() call provided the slot still exists on the primary
> server. It is okay to recreate such slots as long as these are not consumable
> on the standby (which is the case currently). This situation may occur due to
> the following reasons:
>
> - The max_slot_wal_keep_size on the standby is insufficient to retain WAL
>   records from the restart_lsn of the slot.
> - primary_slot_name is temporarily reset to null and the physical slot is
>   removed.
>
> Changing the primary wal_level to a level lower than logical is only possible
> if the logical slots are removed on the primary, so it's expected to see
> the slots being removed on the standby too (and re-created if they are
> re-created on the primary).
> =====

Thanks for the feedback. I have incorporated the suggestions in v80.

thanks
Shveta