Re: Synchronizing slots from primary to standby

On Thu, Feb 22, 2024 at 4:35 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Suppose that in synchronize_slots() the query would be:
>
>     const char *query = "SELECT slot_name, plugin, confirmed_flush_lsn,"
>         " restart_lsn, catalog_xmin, two_phase, failover,"
>         " database, conflict_reason"
>         " FROM pg_catalog.pg_replication_slots"
>         " WHERE failover and NOT temporary and 1 = 1";
>
> Then my comment is to rewrite it to:
>
>     const char *query = "SELECT slot_name, plugin, confirmed_flush_lsn,"
>         " restart_lsn, catalog_xmin, two_phase, failover,"
>         " database, conflict_reason"
>         " FROM pg_catalog.pg_replication_slots"
>         " WHERE failover and NOT temporary and 1 OPERATOR(pg_catalog.=) 1";
>
> to ensure the operator "=" is coming from the pg_catalog schema.
>

Thanks for the details, but slot-sync does not use SPI calls, it uses
libpqrcv calls. So is this change needed?

thanks
Shveta