Re: Grants on sequences via Grant Wizard fix patch

Поиск
Список
Период
Сортировка
От Dhiraj Chawla
Тема Re: Grants on sequences via Grant Wizard fix patch
Дата
Msg-id CAJgtxT5PB2wsQ-Z7RxNkoCK=tspjvDY5CHsetd5PgZ9Ewgj_zQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Grants on sequences via Grant Wizard fix patch  (Dave Page <dpage@pgadmin.org>)
Ответы Re: Grants on sequences via Grant Wizard fix patch
Список pgadmin-hackers
Дерево обсуждения
Hi Dave,

Please find attached the updated patch after having removed the RULE grant. I have also made minor tweaks to my earlier code, by which when user selects a Sequences container and selects the grant wizard option, in the dialog the user sees only the grants options relevant to Sequence and not all the other options.

Let me know your view on this patch.

Thanks,



On Thu, May 23, 2013 at 1:32 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, May 22, 2013 at 8:01 PM, Dhiraj Chawla
<dhiraj.chawla@enterprisedb.com> wrote:
> Hi Dave,
>
> As per the issue reported on pgadmin-support mailing list related to grant
> wizard treating a sequence like a table and giving it grants similar to that
> of the table, attached is the patch that fixes this issue. According to this
> patch now we check for the sequences object separately and provide grants to
> it accordingly. Also according the mail, it was also reported the we were
> missing the USAGE grant in the Grant Wizard which I have added to it as part
> of this patch.

Cool, thanks.

> One thing I noticed though, as we have the RULE grant still existing in the
> Grant Wizard, which has been removed after PG-8.1. As the minimum supported
> version by the community is 8.4, should we remove the RULE grant from the
> Wizard??

Yes please. Can you update the patch with that change?

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
regards,

Dhiraj Chawla
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522
Вложения

В списке pgadmin-hackers по дате отправления: