Re: Skipping logical replication transactions on subscriber side

On Tue, Jan 18, 2022 at 5:05 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I've attached a rebased patch.

A couple of comments for the v8 patch:

doc/src/sgml/logical-replication.sgml

(1)
Strictly-speaking it's the transaction, not transaction ID, that
contains changes, so suggesting minor change:

BEFORE:
+   The transaction ID that contains the change violating the constraint can be
AFTER:
+   The ID of the transaction that contains the change violating the
constraint can be


doc/src/sgml/ref/alter_subscription.sgml

(2) apply_handle_commit_internal
It's not entirely apparent what commits the clearing of subskixpid
here, so I suggest the following addition:

BEFORE:
+ * clear subskipxid of pg_subscription.
AFTER:
+ * clear subskipxid of pg_subscription, then commit.


Regards,
Greg Nancarrow
Fujitsu Australia