Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Дата
Msg-id CAJ7c6TNhRz7o=1LcwpQOb6v_8-Kz7TXKdty2-=bT=VaVevi7PQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS  (Peter Eisentraut <peter@eisentraut.org>)
Ответы Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Список pgsql-hackers
Дерево обсуждения 
Hi,

> > Thanks. I see a few pieces of code that use special FOO_NUMBER enum
> > values instead of a macro. Should we refactor these pieces
> > accordingly? PFA another patch.
>
> I think this is a sensible improvement.
>
> But please keep the trailing commas on the last enum items.

Thanks, fixed.

-- 
Best regards,
Aleksander Alekseev
Вложения

В списке pgsql-hackers по дате отправления: