Re: POC: Extension for adding distributed tracing - pg_tracing
От | Aleksander Alekseev |
---|---|
Тема | Re: POC: Extension for adding distributed tracing - pg_tracing |
Дата | |
Msg-id | CAJ7c6TN_=GDziai-FLw74_PWLAfzyUZBFNR1UbjgsfHOCtEs8A@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: POC: Extension for adding distributed tracing - pg_tracing (Nikita Malakhov <hukutoc@gmail.com>) |
Ответы |
Re: POC: Extension for adding distributed tracing - pg_tracing
|
Список | pgsql-hackers |
Nikita, > This patch looks very interesting, I'm working on the same subject too. But I've used > another approach - I'm using C wrapper for C++ API library from OpenTelemetry, and > handle span storage and output to this library. There are some nuances though, but it > is possible. Have you tried to use OpenTelemetry APIs instead of implementing all > functionality around spans? I don't think that PostgreSQL accepts such kind of C++ code, not to mention the fact that the PostgreSQL license is not necessarily compatible with Apache 2.0 (I'm not a lawyer; this is not a legal advice). Such a design decision will probably require using separate compile flags since the user doesn't necessarily have a corresponding dependency installed. Similarly to how we do with LLVM, OpenSSL, etc. So -1 to the OpenTelemetry C++ library and +1 to the properly licensed C implementation without 3rd party dependencies from me. Especially considering the fact that the implementation seems to be rather simple. -- Best regards, Aleksander Alekseev
В списке pgsql-hackers по дате отправления: