Re: Add common function ReplicationOriginName.

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Re: Add common function ReplicationOriginName.
Дата
Msg-id CAJ7c6TMVjmNmqqGkYM2uwdFnZUAf39ViSS+P3WxccB5BZ4VAVw@mail.gmail.com
обсуждение исходный текст
Ответ на Add common function ReplicationOriginName.  (Peter Smith <smithpb2250@gmail.com>)
Ответы Re: Add common function ReplicationOriginName.  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Hi Peter,

> PSA a patch to add a common function ReplicationOriginName

The patch looks good to me.

One nitpick I have is that the 2nd argument of snprintf is size_t
while we are passing int's. Your patch is consistent with the current
implementation of ReplicationOriginNameForTablesync() and similar
functions in tablesync.c. However I would like to mention this in case
the committer will be interested in replacing ints with Size's while
on it.


-- 
Best regards,
Aleksander Alekseev



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Himanshu Upadhyaya
Дата:
Сообщение: Re: HOT chain validation in verify_heapam()
Следующее
От: "Drouvot, Bertrand"
Дата:
Сообщение: Re: Patch to address creation of PgStat* contexts with null parent context