Re: Logical Replication of sequences
От | Peter Smith |
---|---|
Тема | Re: Logical Replication of sequences |
Дата | |
Msg-id | CAHut+PvSM6GTe-_sxnvhuv0VoM5CVSMvOPqWWs357kqdV_VEZw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Logical Replication of sequences (vignesh C <vignesh21@gmail.com>) |
Ответы |
Re: Logical Replication of sequences
|
Список | pgsql-hackers |
Here are some review comments for patch v20240720-0002. ====== 1. Commit message: 1a. The commit message is stale. It is still referring to functions and views that have been moved to patch 0003. 1b. "ALL SEQUENCES" is not a command. It is a clause of the CREATE PUBLICATION command. ====== doc/src/sgml/ref/create_publication.sgml nitpick - publication name in the example /allsequences/all_sequences/ ====== src/bin/psql/describe.c 2. describeOneTableDetails Although it's not the fault of this patch, this patch propagates the confusion of 'result' versus 'res'. Basically, I did not understand the need for the variable 'result'. There is already a "PGResult *res", and unless I am mistaken we can just keep re-using that instead of introducing a 2nd variable having almost the same name and purpose. ~ nitpick - comment case nitpick - rearrange comment ====== src/test/regress/expected/publication.out (see publication.sql) ====== src/test/regress/sql/publication.sql nitpick - tweak comment ====== Kind Regards, Peter Smith. Fujitsu Australia
Вложения
В списке pgsql-hackers по дате отправления: