Re: row filtering for logical replication

I noticed that there was a build-farm failure on the machine 'komodoensis' [1]

#   Failed test 'check replicated rows to tab_rowfilter_toast'
#   at t/028_row_filter.pl line 687.
#          got: ''
#     expected: 't|1'
# Looks like you failed 1 test of 20.
[18:21:24] t/028_row_filter.pl ................
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/20 subtests

That failure looks intermittent because from the history you can see
the same machine already passed multiple times in this test case.

When I investigated the test case I noticed there seems to be a
missing "catchup" ($node_publisher->wait_for_catchup($appname);), so
sometimes if the replication happens too slowly then the expected row
might not be found on the subscriber side.

I will post a patch to fix this shortly.

------
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=komodoensis&dt=2022-02-23%2016%3A12%3A03

Kind Regards,
Peter Smith.
Fujitsu Australia.