Re: [PATCH] postgresql.conf.sample comment alignment.

On Tue, Aug 2, 2022 at 10:03 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Peter Smith <smithpb2250@gmail.com> writes:
> > This patch tweaks a some tabbing and replaces some spaces with tabs to
> > improve slightly the comment alignment in file
> > 'postgresql.conf.sample'
>
> Hmm ... the parts you want to change generally look OK to me.
> I wonder if you are looking at it with tab stops set to 4 spaces
> rather than 8 spaces?
>

No. I did fall into that 4/8 trap originally, but I definitely used
:set tapstop=8 when modifying this file.

> While 4 spaces is our convention for C code, postgresql.conf
> is going to be edited by end users who almost certainly have their
> editors set up for 8 spaces, so it's going to look funny to them
> if the comments are aligned on the assumption of 4 spaces.
>
> One idea for avoiding confusion is to legislate that we won't
> use tabs at all in this file (which we could enforce via
> .gitattributes, I think).  But that might just be making things
> equally inconvenient for everybody.
>

------
Kind Regards,
Peter Smith
Fujitsu Australia