Re: row filtering for logical replication

On Thu, Dec 30, 2021 at 7:57 PM wangw.fnst@fujitsu.com
<wangw.fnst@fujitsu.com> wrote:
>
> On Mon, Dec 28, 2021 9:03 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote:
> > Attach a top up patch 0004 which did the above changes.
>
> A few comments about v55-0001 and v55-0002.
...
> v55-0002
> In function pgoutput_row_filter_init, I found almost whole function is in the if
> statement written like this:
> static void
> pgoutput_row_filter_init()
> {
>     Variable declaration and initialization;
>     if (!entry->exprstate_valid)
>     {
>         ......
>     }
> }
> What about changing this if statement like following:
> if (entry->exprstate_valid)
>         return;
>

Modified in v58 [1] as suggested

------
[1] https://www.postgresql.org/message-id/CAHut%2BPvkswkGLqzYo7z9rwOoDeLtUk0PEha8kppNvZts0h22Hw%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia