On Fri, Jan 12, 2024 at 4:07 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Mon, Jan 30, 2023 at 8:36 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Zheng Li <zhengli10@gmail.com> writes:
> > > The behavior is due to the following code
> > > https://github.com/postgres/postgres/blob/master/src/backend/commands/define.c#L113
> >
> > Yeah, so you can grep for places that have this behavior by looking
> > for defGetBoolean calls ... and there are quite a few. That leads
> > me to the conclusion that we'd better invent a fairly stylized
> > documentation solution that we can plug into a lot of places,
> > rather than thinking of slightly different ways to say it and
> > places to say it. I'm not necessarily opposed to Peter's desire
> > to fix replication-related commands first, but we have more to do
> > later.
> >
> > I'm also not that thrilled with putting the addition up at the top
> > of the relevant text. This behavior is at least two decades old,
> > so if we've escaped documenting it at all up to now, it can't be
> > that important to most people.
> >
> > I also notice that ALTER SUBSCRIPTION has fully three different
> > sub-sections with about equal claims on this note, if we're going
> > to stick it directly into the affected option lists.
> >
> > That all leads me to propose that we add the new text at the end of
> > the Parameters <refsect1> in the affected man pages. So about
> > like the attached. (I left out alter_publication.sgml, as I'm not
> > sure it needs its own copy of this text --- it doesn't describe
> > individual parameters at all, just refer to CREATE PUBLICATION.)
> >
> > regards, tom lane
> >
>
> Hi,
>
> Here is a similar update for another page: "55.4 Streaming Replication
> Protocol" [0]. This patch was prompted by a review comment reply at
> [1] (#2).
>
> I've used text almost the same as the boilerplate text added by the
> previous commit [2]
>
> ~
>
> PSA patch v4.
>
> ======
> [0] https://www.postgresql.org/docs/devel/protocol-replication.html
> [1]
https://www.postgresql.org/message-id/OS0PR01MB571663BCE8B28597D462FADE946A2%40OS0PR01MB5716.jpnprd01.prod.outlook.com
> [2] https://github.com/postgres/postgres/commit/ec7e053a98f39a9e3c7e6d35f0d2e83933882399
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
Bump.
Kind Regards,
Peter Smith.
Fujitsu Australia