Re: incorrect handling of the timeout in pg_receivexlog
От | Fujii Masao |
---|---|
Тема | Re: incorrect handling of the timeout in pg_receivexlog |
Дата | |
Msg-id | CAHGQGwHwsPcDaf0SeDokGg5d05yrFqwdJ2bRTCwDe3ATyebpDQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: incorrect handling of the timeout in pg_receivexlog (Magnus Hagander <magnus@hagander.net>) |
Ответы |
Re: incorrect handling of the timeout in pg_receivexlog
|
Список | pgsql-hackers |
On Thu, May 24, 2012 at 4:52 AM, Magnus Hagander <magnus@hagander.net> wrote: > On Wed, May 23, 2012 at 8:11 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >> On Tue, May 22, 2012 at 11:04 PM, Robert Haas <robertmhaas@gmail.com> wrote: >>> On Mon, May 14, 2012 at 2:24 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >>>> On Fri, May 11, 2012 at 11:43 PM, Magnus Hagander <magnus@hagander.net> wrote: >>>>> Should we go down the easy way and just reject connections when the flag is >>>>> mismatching between the client and the server (trivial to do - see the >>>>> attached patch)? >>>> >>>> + char *tmpparam; >>>> >>>> You forgot to add "const" before "char", which causes a compile-time warning. >>> >>> I went ahead and committed this, with this fix and a slight change to >>> the message text. >> >> Thanks! >> >>> Hope that's OK with everyone... >> >> What about calling PQfinish() before exit() to avoid "unexpected EOF >> connection" error? >> Patch attached. > > Makes sense, applied. Thanks! So, let's go back to the original problem: pg_receivexlog still doesn't work fine under --disable-integer-datetimes. I previously posted the patch which fixes that problem. http://archives.postgresql.org/message-id/CAHGQGwFutqnFPBYcHUCuoy1zMVDXto=o4OgsjrBWxW4zj2TCSw@mail.gmail.com Attached is the updated version of the patch. Comments? Regards, -- Fujii Masao
Вложения
В списке pgsql-hackers по дате отправления: