Re: [HACKERS] Creating backup history files for backups taken from standbys

On Thu, Jan 11, 2018 at 9:47 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Thu, Jan 11, 2018 at 07:10:50PM +0900, Masahiko Sawada wrote:
>> On Sun, Jan 7, 2018 at 1:35 AM, David Steele <david@pgmasters.net> wrote:
>>> On 1/6/18 3:48 AM, Michael Paquier wrote:
>>>> On Fri, Jan 5, 2018 at 11:27 PM, Simon Riggs <simon@2ndquadrant.com>
>>>> wrote:
>>>>
>>>>> Which also makes it a smaller and clearer patch
>>>>
>>>> Yes, this generates less diffs, reducing the likelihood of bugs. What
>>>> do you think about the v3 attached?
>>>
>>>
>>> I agree that this is a cleaner solution.
>>>
>>
>> +1. And the changes looks good to me.

The patch basically looks good to me. Here are some small comments.

   <para>
      The backup history file is not created in the database cluster backed up.
   </para>

The above should be deleted in pg_basebackup.sgml.

    * During recovery, since we don't use the end-of-backup WAL
    * record and don't write the backup history file, the

This comment needs to be updated in xlog.c.

Regards,

-- 
Fujii Masao