Re: postgresql.auto.conf and reload

On Thu, Aug 7, 2014 at 12:36 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Wed, Aug 6, 2014 at 1:32 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Tue, Jul 29, 2014 at 9:26 PM, Amit Kapila <amit.kapila16@gmail.com>
>> wrote:
>> >
>> > The reason is that during startup DataDir is not set by the time server
>> > processes config file due to which we process .auto.conf file in second
>> > pass.  I think ideally it should ignore the invalid setting in such a
>> > case
>> > as it does during reload, however currently there is no good way to
>> > process .auto.conf  incase DataDir is not set, so we handle it
>> > separately
>> > in second pass.
>>
>> What about picking up only data_directory at the first pass?
>
> I think that will workout and for that I think we might need to add
> few checks during ProcessConfigFile.  Do you want to address it
> during parsing of config file or during setting of values?

I prefer "during paring". The attached patch does that. In this patch,
the first call of ProcessConfigFile() picks up only data_directory. One
concern of this patch is that the logic is a bit ugly. Do you have any
other better idea?

Regards,

--
Fujii Masao