Re: The return value of allocate_recordbuf()
| От | Fujii Masao |
|---|---|
| Тема | Re: The return value of allocate_recordbuf() |
| Дата | |
| Msg-id | CAHGQGwGMKAYAuj7h1ftBrbk+AWdb8C2-4P5KwrZ3bWzL2x54Aw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: The return value of allocate_recordbuf() (Michael Paquier <michael.paquier@gmail.com>) |
| Ответы |
Re: The return value of allocate_recordbuf()
|
| Список | pgsql-hackers |
On Fri, Apr 3, 2015 at 8:37 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Fri, Apr 3, 2015 at 6:35 PM, Fujii Masao wrote: >> Regarding the second patch, you added the checks of the return value of >> XLogReaderAllocate(). But it seems half-baked. XLogReaderAllocate() still >> uses palloc(), but don't we need to replace it with palloc_extended(), too? > > Doh, you are right. I missed three places. Attached is a new patch > completing the fix. Thanks for the patch! I updated two source code comments and changed the log message when XLogReaderAllocate returns NULL within XLOG_DEBUG block. Just pushed. Regards, -- Fujii Masao
В списке pgsql-hackers по дате отправления: