Re: Some bugs in psql_complete of psql

On Fri, Nov 6, 2015 at 11:27 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, thank you for the comments.
>
> The revised version of this patch is attached.

Thanks for updating the patch!

I tested whether the following patterns work as expected or not.

CREATE UNIQUE INDEX CONCURRENTLY name ON
CREATE UNIQUE INDEX CONCURRENTLY ON
CREATE UNIQUE INDEX name ON
CREATE UNIQUE INDEX ON
CREATE INDEX CONCURRENTLY name ON
CREATE INDEX CONCURRENTLY ON
CREATE INDEX name ON
CREATE INDEX ON

Then I found the following problems.

"CREATE UNIQUE INDEX CONCURRENTLY <tab>" didn't suggest "ON".
"CREATE UNIQUE INDEX ON <tab>" suggested nothing.
"CREATE INDEX CONCURRENTLY <tab>" didn't suggest "ON".
"CREATE INDEX ON <tab>" suggested nothing.

BTW, I found that tab-completion for DROP INDEX has the following problems.

"DROP INDEX <tab>" didn't suggest "CONCURRENTLY".
"DROP INDEX CONCURRENTLY name <tab>" suggested nothing.

Regards,

-- 
Fujii Masao