Re: Incorrect comment in postgres_fdw.c
От | Fujii Masao |
---|---|
Тема | Re: Incorrect comment in postgres_fdw.c |
Дата | |
Msg-id | CAHGQGwFp3xS3YxKZw1Hr=3XGP7uaJen6mwjZJVn5c30kNt9Z9g@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Incorrect comment in postgres_fdw.c (Shigeru Hanada <shigeru.hanada@gmail.com>) |
Ответы |
Re: Incorrect comment in postgres_fdw.c
|
Список | pgsql-hackers |
On Mon, Jul 14, 2014 at 7:31 PM, Shigeru Hanada <shigeru.hanada@gmail.com> wrote: > Fujita-san, > > 2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>: >> I think the following comment for store_returning_result() in >> postgres_fdw.c is not right. >> >> /* PGresult must be released before leaving this function. */ >> >> I think PGresult should not be released before leaving this function *on >> success* in that function. >> >> (I guess the comment has been copied and pasted from that for >> get_remote_estimate().) > > +1 for just removing the comment, because header comment clearly > mentions necessity of releasing the PGresult. Committed. Thanks for the report! Regards, -- Fujii Masao
В списке pgsql-hackers по дате отправления: