Re: Trivial fix for comment of function table_tuple_lock

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: Trivial fix for comment of function table_tuple_lock
Дата
Msg-id CAHGQGwEkxYC_7A8RhWzAjiA2ApoGQ7MLoOALtkueChqc0=J=Sg@mail.gmail.com
обсуждение исходный текст
Ответ на Trivial fix for comment of function table_tuple_lock  (Chao Li <li.evan.chao@gmail.com>)
Ответы Re: Trivial fix for comment of function table_tuple_lock
Список pgsql-hackers
On Thu, Sep 11, 2025 at 2:40 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Hackers,
>
> Just fixed an one-word error in comment. Please take a look.

Thanks for the patch! LGTM.

It looks like this happened because heapam_tuple_lock() and heap_lock_tuple()
use the argument relation instead of rel, and the comments for
table_lock_tuple() were probably copied from heap_lock_tuple(),
leaving relation in place by mistake.

By the way, I noticed another typo in the comments for heap_lock_tuple():
the input parameter description for tid ("TID of tuple to lock")
should be removed,
since that function doesn’t take tid. How about fixing both issues in
the same patch,
since there’s no need to commit them separately?

Regards,

--
Fujii Masao



В списке pgsql-hackers по дате отправления: