Re: pg_receivexlog add synchronous mode
От | Fujii Masao |
---|---|
Тема | Re: pg_receivexlog add synchronous mode |
Дата | |
Msg-id | CAHGQGwEeQR=P1OPX5mgEpYhbWgVHeBz+ytH4-n7V2eaJx7qorg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: pg_receivexlog add synchronous mode (<furuyao@pm.nttdata.co.jp>) |
Ответы |
Re: pg_receivexlog add synchronous mode
|
Список | pgsql-hackers |
On Tue, Jul 29, 2014 at 7:07 PM, <furuyao@pm.nttdata.co.jp> wrote: > I have improved the patch by making following changes: > > 1. Since stream_stop() was redundant, stream_stop() at the time of WAL file closing was deleted. > > 2. Change the Flash judging timing for the readability of source code. > I have changed the Flash judging timing , from the continuous message after receiving to > before the feedbackmassege decision of continue statement after execution. Thanks for the updated version of the patch! While reviewing the patch, I found that HandleCopyStream() is still long and which decreases the readability of the source code. So I feel inclined to refactor the HandleCopyStream() more for better readability. What about the attached refactoring patch? Regards, -- Fujii Masao
В списке pgsql-hackers по дате отправления: