Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names
| От | Euler Taveira |
|---|---|
| Тема | Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names |
| Дата | |
| Msg-id | CAH503wBzp3eHhZxTWPMA7rTBsWN2cXYXjB_JLWoqZOfu2x=KXA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names
|
| Список | pgsql-bugs |
On Sat, 20 Jun 2020 at 19:11, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I wrote:
> Agreed as to the bug, but I think we ought to fix it by redefining
> explain_get_index_name's API as "return the bare index name always",
> and let the callers apply quoting.
Concretely, as attached.
I thought about that but decided to go the other way. I agree that mixing
layers (get and format) is not a good idea.
layers (get and format) is not a good idea.
I am unsure about back-patching this, but am leaning to doing so.
Extension authors can always add an ifdef to handle those cases if (s)he
cares about it. Since this bug report did not come from an index-advisor
extension user and that the code is like this for a decade, I bet that is
safe to backpatch to all supported versions.
cares about it. Since this bug report did not come from an index-advisor
extension user and that the code is like this for a decade, I bet that is
safe to backpatch to all supported versions.
BTW, your patch looks good to me.
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-bugs по дате отправления: