Re: redundant error messages
| От | Euler Taveira |
|---|---|
| Тема | Re: redundant error messages |
| Дата | |
| Msg-id | CAH503wAbpk-isL-tCiM=FpaVD1Yb9NXtfw-M869KwEvaSRhi8Q@mail.gmail.com обсуждение исходный текст |
| Ответ на | redundant error messages (Peter Eisentraut <peter.eisentraut@enterprisedb.com>) |
| Ответы |
Re: redundant error messages
|
| Список | pgsql-hackers |
On Thu, 5 Nov 2020 at 09:27, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
A few client tools duplicate error messages already provided by libpq,
such as
pg_rewind: fatal: could not connect to server: could not connect to
server: No such file or directory
Good catch!
Other client tools provide a different error message so in aggregate it
looks like this:
createdb: error: could not connect to database template1: could not
connect to server: No such file or directory
Is the database name important for this message? You should inform which
database you want to connect for all client tools except pg_dumpall. Hence, you
already know which database has the connection problem. IMO the pg_dumpall
message should inform the database name. My suggestion is:
if (fail_on_error)
{
pg_log_error("database \"%s\": %s",
dbname, PQerrorMessage(conn));
exit_nicely(1);
}
and remove the redundant 'could not connect to database %s' from
scripts/common.c.
database you want to connect for all client tools except pg_dumpall. Hence, you
already know which database has the connection problem. IMO the pg_dumpall
message should inform the database name. My suggestion is:
if (fail_on_error)
{
pg_log_error("database \"%s\": %s",
dbname, PQerrorMessage(conn));
exit_nicely(1);
}
and remove the redundant 'could not connect to database %s' from
scripts/common.c.
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: