Re: [pgadmin-hackers][patch] Move to Alembic migration system

On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Hackers,

We review the patch, just noticed a spelling issue so we regenerated the patch.

Thanks.

Your patch was missing README changes. :-)

Committed after adding the necessary changes.

-- Thanks,

Ashesh Vashi

 

Thanks

Joao & Oliver

On Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Joao & Oliver,

On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Hackers,

@Ashesh thanks for the feedback

Here is the reviewed patch with the suggestions of Ashesh.

Disclaimer: We added a new patch file with the changes 

 

I have made some more changes to the patch.

- 'with app.app_context(..)' statement was not required in the 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade function.

- We also need to create other directories (i.e. sessions, storage, directory containing the log-file) during the setup/running the application (if not exists).

- Added proper check in the pgAdmin4.wsgi file (if configuration file exists, or not)

Please review it.

-- Thanks, Ashesh