Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')

Поиск
Список
Период
Сортировка
От Rushabh Lathia
Тема Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')
Дата
Msg-id CAGPqQf0FHZGx5ipBob1rdKzpV=syRAX2Px1tg=m440Eyu_We-Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] CREATE/ALTER ROLE PASSWORD ('value' USING 'method')
Список pgsql-hackers
Дерево обсуждения


On Wed, Mar 8, 2017 at 9:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Michael Paquier <michael.paquier@gmail.com> writes:
> here is a separate thread dedicated to the following extension for
> CREATE/ALTER ROLE: PASSWORD ('value' USING 'method').

The parentheses seem weird ... do we really need those?

+1

I had quick glance to patch and it looks great.

One quick comments:

+            | PASSWORD '(' Sconst USING Sconst ')'
+                {
+                    $$ = makeDefElem("methodPassword",
+                                     (Node *)list_make2(makeString($3),
+                                                        makeString($5)),
+                                     @1);
+                }

methodPassword looks bit weird, can we change it to passwordMethod
or pwdEncryptMethod ?


                        regards, tom lane


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



--
Rushabh Lathia

В списке pgsql-hackers по дате отправления: