Re: run pgindent on a regular basis / scripted manner
От | Jelte Fennema |
---|---|
Тема | Re: run pgindent on a regular basis / scripted manner |
Дата | |
Msg-id | CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: run pgindent on a regular basis / scripted manner (Andrew Dunstan <andrew@dunslane.net>) |
Ответы |
Re: run pgindent on a regular basis / scripted manner
Re: run pgindent on a regular basis / scripted manner |
Список | pgsql-hackers |
Now that the PG16 feature freeze happened I think it's time to bump this thread again. As far as I remember everyone that responded (even previously silent people) were themselves proponents of being more strict around pgindent. I think there's two things needed to actually start doing this: 1. We need to reindent the tree to create an indented baseline 2. We need some automation to complain about unindented code being committed For 2 the upstream thread listed two approaches: a. Install a pre-receive git hook on the git server that rejects pushes to master that are not indented b. Add a test suite that checks if the code is correctly indented, so the build farm would complain about it. (Suggested by Peter E) I think both a and b would work to achieve 2. But as Peter E said, b indeed sounds like less of a divergence of the status quo. So my vote would be for b. If that doesn't achieve 2 for some reason, or turns out to have problems we can always change to a afterwards.
В списке pgsql-hackers по дате отправления: