Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

Thanks - I've applied and pushed the patch for master

, but the REL-1_14 version doesn't apply.

error: patch failed: pgadmin/schema/pgFunction.cpp:808

Applied patch pgadmin/schema/edbPackageFunction.cpp cleanly.

Applying patch pgadmin/schema/pgFunction.cpp with 2 rejects...

Hunk #1 applied cleanly.

Hunk #2 applied cleanly.

Hunk #3 applied cleanly.

Hunk #4 applied cleanly.

Hunk #5 applied cleanly.

Hunk #6 applied cleanly.

Hunk #7 applied cleanly.

Hunk #8 applied cleanly.

Rejected hunk #9.

Rejected hunk #10

Please fix and resubmit that version. Thanks!

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

On Mon, Apr 16, 2012 at 9:52 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Mon, Apr 16, 2012 at 3:03 PM, Sachin Srivastava <sachin.srivastava@enterprisedb.com> wrote:

Ashesh,

In this code block,

360 +                                       (function->GetArgModesArray()[index] == wxT("INOUT") &&

361 +                                        lanname != wxT("edbsql")) ||

362 +                                       function->GetArgModesArray()[index] == wxT("VARIADIC"))

Sachin,

 

Thanks for the review.

Dave,

Please find the updated patches.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

 

lanname should be comapred to 'edbspl'.

Rest all looks good.

On Mon, Apr 9, 2012 at 12:45 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,

During resolving a bug - "Error message is displayed when the packages is clicked", I found that:

- We are not properly handling the default parameters for the functions & procedures properly, when the function is type of 'edbspl'.

- We also do not handle the default parameters for the functions & procedures properly under the packages.

In 'edbspl', we do not allow the default parameters with INOUT parameters and that reflects in the reverse-engineering for those functions & procedures.

Attached patches resolve the above issues for REL-1_14 and master branches.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Regards,
Sachin Srivastava
EnterpriseDB, India

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company