Re: pgadmin4 l10n issues
| От | Ashesh Vashi |
|---|---|
| Тема | Re: pgadmin4 l10n issues |
| Дата | |
| Msg-id | CAG7mmoxNJHLVOhzWEw+-S5yK7ZXAQeviJJRgUeU09tjj=o=29Q@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgadmin4 l10n issues (Alexander Lakhin <exclusion@gmail.com>) |
| Ответы |
Re: pgadmin4 l10n issues
|
| Список | pgadmin-hackers |
On Tue, Oct 24, 2017 at 6:08 PM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hi Ashesh,
23.10.2017 08:21, Ashesh Vashi wrote:No, I didn't. You can find all my attached files here:Hi Dave/Alexander,On Thu, Oct 19, 2017 at 6:43 PM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this, and look into why the remaining strings Alexander notes are not getting translated please?
Did you forget to attach the patch?
https://www.postgresql.org/message-id/5c7914c8-db5f-cb70- a81e-6e9145039935%40gmail.com
I reviewed your patches.
I have committed the first patch.
About the second patch, I understood the issue.
I prefer another approach, instead of proposed by you.
Problem with the approach, you suggested, is: label for 'miscellaneous' Preference object will be always None.
Instead - read the 'raw_value' from the configuration database.
-- Thanks, Ashesh
Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Вложения
В списке pgadmin-hackers по дате отправления: