Re: [pgAdmin4][Patch]: Node issues under catalogs
От | Ashesh Vashi |
---|---|
Тема | Re: [pgAdmin4][Patch]: Node issues under catalogs |
Дата | |
Msg-id | CAG7mmowu90UV_S2bfdnTNUYQeoqL5Gk=s+3PJsKN-C9f8C-qFw@mail.gmail.com обсуждение исходный текст |
Ответ на | [pgAdmin4][Patch]: Node issues under catalogs (Surinder Kumar <surinder.kumar@enterprisedb.com>) |
Список | pgadmin-hackers |
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'
This is wrong - you should not put the group-id as i18n string.
It should be a simple string. i.e. group: 'security'
},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'
Same as above.
}]Please find attached patch and review.
I also found - we're not consistent about showing ACL on all the node.
For some node, we're not showing ACLs in properties mode.
Please send patch with above fixes.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
В списке pgadmin-hackers по дате отправления: