Re: Postgres_fdw join pushdown - wrong results with whole-row reference

<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Mon, Jun 27, 2016 at 3:06 PM, Etsuro
Fujita<span dir="ltr"><<a href="mailto:fujita.etsuro@lab.ntt.co.jp"
target="_blank">fujita.etsuro@lab.ntt.co.jp</a>></span>wrote:<br /><blockquote class="gmail_quote" style="margin:0 0
0.8ex;border-left:1px #ccc solid;padding-left:1ex">On 2016/06/25 4:14, Robert Haas wrote:<br /><blockquote
class="gmail_quote"style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Committed that way.<br
/></blockquote><br/> Thanks for taking care of this!<br /><br /> I found another bug in error handling of whole-row
referencesin join pushdown; conversion_error_callback fails to take into account that get_relid_attribute_name(Oid
relid,AttrNumber attnum) can't handle whole-row references (ie, attnum=0), in which case that would cause cache lookup
errors. Attached is a small patch to address this issue.<br /></blockquote></div><br /></div><div
class="gmail_extra">Doyou have any testcase reproducing the bug here? It would be good to include that test in the
regression.<br/><br /></div><div class="gmail_extra">There is a always a possibility that a user would create a table
(whichcan be used as target for the foreign table) with column named 'wholerow', in which case s/he will get confused
withthis error message.<br /><br /></div><div class="gmail_extra">-- <br /><div class="gmail_signature"
data-smartmail="gmail_signature"><divdir="ltr">Best Wishes,<br />Ashutosh Bapat<br />EnterpriseDB Corporation<br />The
PostgresDatabase Company<br /></div></div></div></div>