Using user mapping OID as hash key for connection hash

Поиск
Список
Период
Сортировка
От Ashutosh Bapat
Тема Using user mapping OID as hash key for connection hash
Дата
Msg-id CAFjFpRe8-0qZ2XdwPoi2u=b5jby8AqH_nksEXk5BJ04D59jP1w@mail.gmail.com
обсуждение исходный текст
Ответы Re: Using user mapping OID as hash key for connection hash
Список pgsql-hackers
Дерево обсуждения
Hi All,
As discussed in postgres_fdw join pushdown thread [1], for two different effective local users which use public user mapping we will be creating two different connections to the foreign server with the same credentials.

Robert suggested [2] that we should use user mapping OID as the connection cache key instead of current userid and serverid.

There are two patches attached here:
1. pg_fdw_concache.patch.short - shorter version of the fix. Right now ForeignTable, ForeignServer have corresponding OIDs saved in these structures. But UserMapping doesn't. Patch adds user mapping OID as a member to this structure. This member is then used as key in GetConnection().
2. pg_fdw_concache.patch.large - most of the callers of GetConnection() get ForeignServer object just to pass it to GetConnection(). GetConnection can obtain ForeignServer by using serverid from UserMapping and doesn't need ForeignServer to be an argument. Larger version of patch has this change.

GetConnection has named the UserMapping argument as just "user", ideally it should have been named user_mapping. But that seems to be too obvious to be unintentional. So, I have left that change.

The patch has added userid and user mapping oid to a debug3 message in GetConnection(). the message is displayed when a new connection to foreign server is created. With only that change, if we run script multi_conn.sql (attached) we see that it's creating two connections when same user mapping is used. Also attached is the output of the same script run on my setup. Since min_messages is set to DEBUG3 there are too many unrelated messages. So, search for "new postgres_fdw connection .." for new connection messages.

I have included the changes to the DEBUG3 message in GetConnection(), since it may be worth committing those changes. In case, reviewers/committers disagree, those chagnes can be removed.
Вложения

В списке pgsql-hackers по дате отправления: