Re: postgres_fdw behaves oddly

<div dir="ltr">Ok. I added that comment to the commitfest and changed the status to "ready for commiter".<br
/></div><divclass="gmail_extra"><br /><div class="gmail_quote">On Wed, Nov 19, 2014 at 1:10 PM, Etsuro Fujita <span
dir="ltr"><<ahref="mailto:fujita.etsuro@lab.ntt.co.jp" target="_blank">fujita.etsuro@lab.ntt.co.jp</a>></span>
wrote:<br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">(2014/11/1915:56), Ashutosh Bapat wrote:<br /></span><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px#ccc solid;padding-left:1ex"><span class=""> On Wed, Nov 19, 2014 at 12:14 PM, Etsuro Fujita<br
/></span><spanclass=""> <<a href="mailto:fujita.etsuro@lab.ntt.co.jp"
target="_blank">fujita.etsuro@lab.ntt.co.jp</a><mailto:<a href="mailto:fujita.etsuro@lab.ntt.co.jp"
target="_blank">fujita.etsuro@lab.ntt.<u></u>co.jp</a>>>wrote:<br />     (2014/11/19 14:58), Ashutosh Bapat
wrote:<br/></span></blockquote><span class=""><br /><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px#ccc solid;padding-left:1ex">         May be we should modify use_physical_tlist() to return<br />
       false in<br />         case of RELKIND_FOREIGN_TABLE, so that we can use tlist in<br />        
create_foreignscan_plan().I do not see any create_*_plan() function<br />         using reltargetlist directly.<br
/></blockquote><br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">    Yeah, I think we can do that, but I'm not sure that we should use<br />     tlist in
create_foreignscan_plan(),not rel->reltargetlist.  How<br />     about leaving this for committers to decide.<br
/></blockquote><br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">I am fine with that. May be you want to add an XXX comment there to<br /> bring it to the
committer'snotice.<br /></blockquote><br /></span> It's ok, but I'm not convinced with your idea.  So, I think the
commentcan be adequately described by you, not by me.  So, my proposal is for you to add the comment to the CF app. 
Couldyou do that?<div class="HOEnZb"><div class="h5"><br /><br /> Thanks,<br /><br /> Best regards,<br /> Etsuro
Fujita<br/></div></div></blockquote></div><br /><br clear="all" /><br />-- <br /><div class="gmail_signature"><div
dir="ltr">BestWishes,<br />Ashutosh Bapat<br />EnterpriseDB Corporation<br />The Postgres Database Company<br
/></div></div></div>