Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)
| От | Ashutosh Bapat |
|---|---|
| Тема | Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs) |
| Дата | |
| Msg-id | CAFjFpRcgJ=+mkL-Q+kY5UCi-Dv_MDBp+iOEhYrRwoq4gR5DvRQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs) (Robert Haas <robertmhaas@gmail.com>) |
| Ответы |
Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)
|
| Список | pgsql-hackers |
On Sat, Feb 6, 2016 at 2:00 AM, Robert Haas <robertmhaas@gmail.com> wrote:
2213 /* Run time cost includes:
2214 * 1. Run time cost (total_cost - startup_cost) of relations being
2215 * joined
2216 * 2. Run time cost of applying join clauses on the cross product of
2217 * the joining relations.
2218 * 3. Run time cost of applying pushed down other clauses on the
2219 * result of join
2220 * 4. Run time cost of applying nonpushable other clauses locally
2221 * on the result fetched from the foreign server.
2222 */
On Fri, Feb 5, 2016 at 4:23 AM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
> I have corrected this in this set of patches. Also, I have included the
> change to build the join relation description while constructing fpinfo in
> the main patch since that avoids repeated building of the same at a small
> cost of constructing relation name for base relations, which goes waste if
> that relation is not going to be part of any pushable join tree.
>
> Ran pgindent as well.
pg_fdw_join_v9.patch does not aplpy.
Here it is rebased. Thanks for the pgindent run and committing core changes. I have to manage only one patch now :)
pgindent is giving trouble with following two comments
2213 /* Run time cost includes:
2214 * 1. Run time cost (total_cost - startup_cost) of relations being
2215 * joined
2216 * 2. Run time cost of applying join clauses on the cross product of
2217 * the joining relations.
2218 * 3. Run time cost of applying pushed down other clauses on the
2219 * result of join
2220 * 4. Run time cost of applying nonpushable other clauses locally
2221 * on the result fetched from the foreign server.
2222 */
which I want itemized with each item starting on separate line. pgindent just bunches everything together.
1159 /*
1160 * For a join relation FROM clause entry is deparsed as
1161 * ((outer relation) <join type> (inner relation) ON (joinclauses)
1162 */
1160 * For a join relation FROM clause entry is deparsed as
1161 * ((outer relation) <join type> (inner relation) ON (joinclauses)
1162 */
where I want the second line as a separate line, but pgindent puts those two line together breaking the continuity of second line content.
How do I make pgindent respect those changes as they are?
Вложения
В списке pgsql-hackers по дате отправления: