Re: XMLDocument (SQL/XML X030)
От | Pavel Stehule |
---|---|
Тема | Re: XMLDocument (SQL/XML X030) |
Дата | |
Msg-id | CAFj8pRDVXtG_7CeoLNem6C+nDFRb558OPzyM_3BaE48x6Qs4Mw@mail.gmail.com обсуждение исходный текст |
Ответ на | XMLDocument (SQL/XML X030) (Jim Jones <jim.jones@uni-muenster.de>) |
Ответы |
Re: XMLDocument (SQL/XML X030)
|
Список | pgsql-hackers |
čt 23. 1. 2025 v 16:06 odesílatel Jim Jones <jim.jones@uni-muenster.de> napsal:
Hi
On 23.01.25 07:50, Pavel Stehule wrote:
> I think so in this form (just forward input to output) I have no
> objection.
>
> There is a benefit with a) possible zero work with migration from db2,
> b) nobody needs to repeat a work which is a correct implementation of
> XMLDOCUMENT function.
>
> Maybe opened question can be implementation like classic scalar
> function or via XmlExpr
>
> In this moment I prefer to use XmlExpr from consistency reasons
To keep it consistent with the existing code, I think this function is
in the right place. There are similar functions in xml.c, e.g.
xmltotext, texttoxml.
I updated the function comment and commit message (v4 attached) to make
things clearer.
Since the status of this patch is waiting on author, is there anything
else I should take a look / improve?
I think documentation should be strongly enhanced. This is probably the hardest part of this patch - explain well what this function does and what it doesn't.
Regards
Pavel
Thanks!
Best regards,Jim
В списке pgsql-hackers по дате отправления: