Re: plpgsql.warn_shadow

On 14/03/14 13:12, Simon Riggs wrote:

On 14 March 2014 11:10, Pavel Stehule <pavel.stehule@gmail.com> wrote:

2014-03-14 12:02 GMT+01:00 Marko Tiikkaja <marko@joh.to>:

On 3/14/14 10:56 AM, Simon Riggs wrote:

The patch looks fine, apart from some non-guideline code formatting
issues.

I'm not sure what you're referring to.  I thought it looked fine.

Having looked at gcc and clang, I have a proposal for naming/API

We just have two variables

    plpgsql.compile_warnings = 'list'    default = 'none'

+1

    plpgsql.compile_errors = 'list'        default = 'none'

Only possible values in 9.4 are 'shadow', 'all', 'none'

what is compile_errors ? We don't allow to ignore any error now.

How about

plpgsql.additional_warnings = 'list'
plpgsql.additional_errors = 'list'

Agree that compile_errors dos not make sense, additional_errors and additional_warnings seems better, maybe plpgsql.extra_warnings and plpgsql.extra_errors?

--
 Petr Jelinek                   http://www.2ndQuadrant.com/

 PostgreSQL Development, 24x7 Support, Training & Services