Re: Proposal: SET ROLE hook

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: Proposal: SET ROLE hook
Дата
Msg-id CAFj8pRCvXpWYR8VWEjcBsMo0dcV7cTboXHFA6DW9RYVNhZs6jg@mail.gmail.com
обсуждение исходный текст
Ответ на Proposal: SET ROLE hook  (Joe Conway <mail@joeconway.com>)
Ответы Re: Proposal: SET ROLE hook  (Joe Conway <mail@joeconway.com>)
Список pgsql-hackers
Дерево обсуждения
Hi

I did a review of this patch.

1. the proposal is clean and there are not any objection against it. I checked a implementation, and it does exactly same what was proposed.

2. This hook has impact only on SET role to XXX statement, what isn't used in our critical path, so there are not any performance impact

3. I was able to apply patch cleanly without any problems, warnings.

4. All regress tests was passed

5. there are not tests and documentation, but it is usual for any hook

I have not any objection

I'll mark this patch as ready for commiter

Regards

Pavel


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Shulgin, Oleksandr"
Дата:
Сообщение: Re: Inconsistent error handling in START_REPLICATION command
Следующее
От: Konstantin Knizhnik
Дата:
Сообщение: Re: Optimizer questions