Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Дата
Msg-id CAFj8pRC6+_8c6PLHbDzCSKEDpkEhcVqyFmJn9_zYUjAwdnUboQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Список pgsql-hackers
Дерево обсуждения


2018-03-16 5:46 GMT+01:00 Michael Paquier <michael@paquier.xyz>:
On Fri, Mar 16, 2018 at 10:25:35AM +0900, Michael Paquier wrote:
>> But, I suppose it is a bit too big.
>
> That's of course not backpatchable.

So in this jungle attached is my counter-proposal.  As the same code
pattern is repeated in three places, we could as well refactor the whole
into a common routine, say in src/common/guc_options.c or similar.
Perhaps just on HEAD and not back-branches as this is always annoying
for packagers on Windows using custom scripts.  Per the lack of
complains only doing something on HEAD, with only a subset of the
parameters which make sense for CREATE FUNCTION is what makes the most
sense in my opinion.

Last patch is good enough solution, I tested it and it is working

Little bit strange is support of GUC, that cannot be atteched to any fx. Probably only PGC_USERSET, maybe PGC_SUSET has sense there

+                if (pg_strcasecmp(configitem, "DateStyle") == 0 ||
+                    pg_strcasecmp(configitem, "listen_addresses") == 0 ||
+                    pg_strcasecmp(configitem, "local_preload_libraries") == 0 ||
+                    pg_strcasecmp(configitem, "log_destination") == 0 ||
+                    pg_strcasecmp(configitem, "plpgsql.extra_errors") == 0 ||
+                    pg_strcasecmp(configitem, "plpgsql.extra_warnings") == 0 ||
+                    pg_strcasecmp(configitem, "search_path") == 0 ||
+                    pg_strcasecmp(configitem, "session_preload_libraries") == 0 ||
+                    pg_strcasecmp(configitem, "shared_preload_libraries") == 0 ||
+                    pg_strcasecmp(configitem, "synchronous_standby_names") == 0 ||
+                    pg_strcasecmp(configitem, "temp_tablespaces") == 0 ||
+                    pg_strcasecmp(configitem, "wal_consistency_checking") == 0)


another idea, how to solve this issue for extensions. The information about format of extensions GUC can be stored in new column pg_extension - maybe just a array of list of LIST GUC.

CREATE EXTENSION plpgsql ...
   GUC_PREFIX 'plpgsql'
   LIST_GUC ('extra_errors','extra_warnings')
   ...

Regards

Pavel

 

As mentioned in this bug, the handling of empty values gets kind of
tricky as in this case proconfig stores a set of quotes and not an
actual value:
https://www.postgresql.org/message-id/152049236165.23137.5241258464332317087@wrigleys.postgresql.org
--
Michael

В списке pgsql-hackers по дате отправления: