Re: proposal: new long psql parameter --on-error-stop
От | Pavel Stehule |
---|---|
Тема | Re: proposal: new long psql parameter --on-error-stop |
Дата | |
Msg-id | CAFj8pRBonaGyknzewBnwzQ5pt3YmdAX9ptYOK44qzoXfEAi4mQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: proposal: new long psql parameter --on-error-stop ("MauMau" <maumau307@gmail.com>) |
Ответы |
Re: proposal: new long psql parameter --on-error-stop
Re: proposal: new long psql parameter --on-error-stop |
Список | pgsql-hackers |
Hello
2014-06-21 15:51 GMT+02:00 MauMau <maumau307@gmail.com>:
eFrom: "Pavel Stehule" <pavel.stehule@gmail.com>here is a prototype:
The patch applied and built with success. There are a few minor things:
(1)
help_variables() lacks description of some variables such as SINGLELINE and SINGLESTEP. I think this help should list all available variables, because users may want to know the existence of those missing variables. Based on this, modify these lines: remove "some" from the first line and the entire second line.
+ printf(_("List of some variables (options) for use from command line.\n"));
+ printf(_("Complete list you find in psql section in the PostgreSQL documentation.\n\n"));
I fixed it
(2)
The indent is different from other lines. Leave just two spaces at the beginning of the line.
+ printf(_(" --help-variables list of available configuration variables (options), then exit\n"));
I am not sure in this point. It is aligned left with all long options:
-?, --help show this help, then exit
--help-variables list of available configuration variables (options), then exit
Input and output options:
-a, --echo-all echo all input from script
-e, --echo-queries echo commands sent to server
-E, --echo-hidden display queries that internal commands generate
-?, --help show this help, then exit
--help-variables list of available configuration variables (options), then exit
Input and output options:
-a, --echo-all echo all input from script
-e, --echo-queries echo commands sent to server
-E, --echo-hidden display queries that internal commands generate
I am thinking so current implementation has sense.
(3)
This change is unnecessary. See src/bin/pg_dumpall.c for similar switches.
- while ((c = getopt_long(argc, argv, "aAc:d:eEf:F:h:HlL:no:p:P:qR:sStT:U:v:VwWxXz?01",
or+ while ((c = getopt_long(argc, argv, "aAc:d:eEf:F:h:HlL:no:p:P:qR:sStT:U:v:VwWxXz?001",
fixed
Regards
MauMau
updated patch is in attachment
Regards
Pavel
Вложения
В списке pgsql-hackers по дате отправления: