Re: Wrong usage of pqMsg_Close message code?
От | Pavel Stehule |
---|---|
Тема | Re: Wrong usage of pqMsg_Close message code? |
Дата | |
Msg-id | CAFj8pRBKa2ey+Nm_drj_5Fk-3_zBP7uezP2OrQT1pHeBO7m=6A@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Wrong usage of pqMsg_Close message code? (Aleksander Alekseev <aleksander@timescale.com>) |
Ответы |
Re: Wrong usage of pqMsg_Close message code?
Re: Wrong usage of pqMsg_Close message code? |
Список | pgsql-hackers |
Hi
po 28. 8. 2023 v 14:00 odesílatel Aleksander Alekseev <aleksander@timescale.com> napsal:
Hi Pavel,
> There is message PqMsgClose, but this should be used from client side. Here should be used PqMsg_CommandComplete instead?
It seems so. This change was introduced in f4b54e1ed98 [1]:
```
--- a/src/backend/tcop/dest.c
+++ b/src/backend/tcop/dest.c
@@ -176,7 +176,7 @@ EndCommand(const QueryCompletion *qc, CommandDest
dest, bool force_undecorated_o
len = BuildQueryCompletionString(completionTag, qc,
force_undecorated_output);
- pq_putmessage('C', completionTag, len + 1);
+ pq_putmessage(PqMsg_Close, completionTag, len + 1);
case DestNone:
case DestDebug
```
It should have been PqMsg_CommandComplete.
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f4b54e1ed98
here is a patch - all tests passed
Regards
Pavel
--
Best regards,
Aleksander Alekseev
Вложения
В списке pgsql-hackers по дате отправления: