Re: Modernizing our GUC infrastructure
От | Pavel Stehule |
---|---|
Тема | Re: Modernizing our GUC infrastructure |
Дата | |
Msg-id | CAFj8pRBHSAHdainq5tRhN2Nns62h9-SZi0pvNq9DTe0VM6M1=g@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Modernizing our GUC infrastructure (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
I think a large part of the reason the schema-variables patch
has gone sideways for so many years is that it's an ambitious
overdesign.
Last two weeks this patch is shorter and shorter. I removed a large part related to check of type consistency, because I can do this check more easily - and other work is done by dependencies.
Big thanks to Julien - it does a lot of work and he shows me a lot of issues and possibilities on how to fix it. With Julien work this patch moved forward. Years before it was just a prototype.
This patch is not too complex - important part is session_variable.c with 1500 lines , and it is almost simple code - store value to hashtab, and cleaning hash tab on sinval or on transaction end or abort + debug routine.
[pavel@localhost commands]$ cloc session_variable.c
1 text file.
1 unique file.
0 files ignored.
github.com/AlDanial/cloc v 1.90 T=0.02 s (50.0 files/s, 77011.1 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
C 1 257 463 820
-------------------------------------------------------------------------------
1 text file.
1 unique file.
0 files ignored.
github.com/AlDanial/cloc v 1.90 T=0.02 s (50.0 files/s, 77011.1 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
C 1 257 463 820
-------------------------------------------------------------------------------
In other files there are +/- mechanical code
regards, tom lane
В списке pgsql-hackers по дате отправления: