Re: [Proposal] Global temporary tables

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: [Proposal] Global temporary tables
Дата
Msg-id CAFj8pRAqML3Jpp3iYpGNPWepdz=SMjxLZQDKy0UNUSxtA8mLSA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [Proposal] Global temporary tables  (曾文旌 <wenjing.zwj@alibaba-inc.com>)
Ответы Re: [Proposal] Global temporary tables  (曾文旌 <wenjing.zwj@alibaba-inc.com>)
Список pgsql-hackers
Hi

čt 11. 6. 2020 v 4:13 odesílatel 曾文旌 <wenjing.zwj@alibaba-inc.com> napsal:

2020年6月9日 下午8:15,Prabhat Sahu <prabhat.sahu@enterprisedb.com> 写道:



On Wed, Apr 29, 2020 at 8:52 AM 曾文旌 <wenjing.zwj@alibaba-inc.com> wrote:
2020年4月27日 下午9:48,Prabhat Sahu <prabhat.sahu@enterprisedb.com> 写道:

Thanks Wenjing, for the fix patch for previous issues.
I have verified the issues, now those fix look good to me.
But the below error message is confusing(for gtt2).

postgres=# drop table gtt1;
ERROR:  cannot drop global temp table gtt1 when other backend attached it.

postgres=# drop table gtt2;
ERROR:  cannot drop index idx2 on global temp table gtt2 when other backend attached it.


I feel the above error message shown for "DROP TABLE gtt2;" is a bit confusing(looks similar to DROP INDEX gtt2;).
If possible, can we keep the error message simple as "ERROR:  cannot drop global temp table gtt2 when other backend attached it."?
I mean, without giving extra information for the index attached to that GTT.
Fixed the error message to make the expression more accurate. In v33.
 
Thanks Wenjing. We verified your latest patch(gtt_v33) focusing on all reported issues and they work fine. 
Thanks.
--

I'm very glad to hear such good news.
I am especially grateful for your professional work on GTT.
Please feel free to let me know if there is anything you think could be improved.


Thanks.


Wenjing

this patch needs rebase

Regards

Pavel


With Regards,
Prabhat Kumar Sahu
EnterpriseDB: http://www.enterprisedb.com


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: min_safe_lsn column in pg_replication_slots view
Следующее
От: Robert Haas
Дата:
Сообщение: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit