Re: Function array_agg(array)
| От | Pavel Stehule |
|---|---|
| Тема | Re: Function array_agg(array) |
| Дата | |
| Msg-id | CAFj8pRAdLb=frxbCFOoG4v-mvsXuVh8wAHR80oWNhwm3-d1tYQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Function array_agg(array) (Ali Akbar <the.apaan@gmail.com>) |
| Ответы |
Re: Function array_agg(array)
Re: Function array_agg(array) |
| Список | pgsql-hackers |
2014-10-27 11:20 GMT+01:00 Ali Akbar <the.apaan@gmail.com>:
2014-10-27 16:15 GMT+07:00 Pavel Stehule <pavel.stehule@gmail.com>:* some API simplification of new builder - we should not to create identical API, mainly it has no sense* move tests of old or new builder style for array sublink out of main cyclesHiI did some minor changes in codeminor changes in the patch:* remove array_agg_finalfn_internal declaration in top of array_userfuncs.c* fix comment of makeMdArray* fix return of makeMdArray* remove unnecesary changes to array_agg_finalfn
super
I tested last version and I have not any objections.
1. We would to have this feature - it is long time number of our ToDo List
2. Proposal and design of multidimensional aggregation is clean and nobody has objection here.
3. There is zero impact on current implementation. From performance reasons it uses new array optimized aggregator - 30% faster for this purpose than current (scalar) array aggregator
4. Code is clean and respect PostgreSQL coding rules
5. There are documentation and necessary regress tests
6. Patching and compilation is clean without warnings.
This patch is ready for commit
Thank you for patch
Regards
Pavel
Pavel
Regards,--Ali Akbar
В списке pgsql-hackers по дате отправления: