Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate()
| От | Dilip Kumar |
|---|---|
| Тема | Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate() |
| Дата | |
| Msg-id | CAFiTN-vMGg3EEe4icesj4LJ_g0JWYq0SqHEPbtQzm+fwfaz4cg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate() ("Drouvot, Bertrand" <bdrouvot@amazon.com>) |
| Ответы |
Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate()
|
| Список | pgsql-hackers |
On Mon, Sep 6, 2021 at 8:54 PM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
Thanks for your feedback!
That seems indeed more logical, so I see 3 options to do so:
1) Add a new API say ReorderBufferChangeMemorySubstractSize() (with a Size as one parameter) and make use of it in ReorderBufferToastReplace()
2) Add a new "Size" parameter to ReorderBufferChangeMemoryUpdate(), so that if this parameter is > 0 then it would be used instead of "sz = ReorderBufferChangeSize(change)"
3) Do the substraction directly into ReorderBufferToastReplace() without any API
I'm inclined to go for option 2), what do you think?
Yet another option could be to create a new API say ReorderBufferReplaceChangeMemoryUpdate(), which takes, 2 parameters, oldchange, and newchange as inputs, it will compute the difference and add/subtract that size. Logically, that is what we are actually trying to do right? i.e. replacing old change with the new change.
В списке pgsql-hackers по дате отправления: