Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

Поиск
Список
Период
Сортировка
От Dilip Kumar
Тема Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Дата
Msg-id CAFiTN-sDLtGeK3HpH4XPZEOwZOQ7xPJMvJeuSdZJfo_WHOz0Cw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Move pg_attribute.attcompression to earlier in struct for reduced size?  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Tue, 25 May 2021 at 11:16 AM, Michael Paquier <michael@paquier.xyz> wrote:
On Mon, May 24, 2021 at 02:46:11PM +0530, Dilip Kumar wrote:
> Like this.
>   if (TupleDescAttr(newTupDesc, i)->attisdropped)
>      isnull[i] = true;
>   else
>      tup_values[i] = values[i];

That would work.  Your suggestion, as I understood it first, makes the
code simpler by not using tup_values at all as the set of values[] is
filled when the values and nulls are extracted.  So I have gone with
this simplification, and applied the patch (moved a bit the comments
while on it).

Perfect.  That looks much better.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Neil Chen
Дата:
Сообщение: Re: [PATCH] In psql \?, add [+] annotation where appropriate
Следующее
От: Dilip Kumar
Дата:
Сообщение: Re: Different compression methods for FPI