Re: [patch] Help information for pg_dump

On Tue, Jan 19, 2021 at 11:24 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Tue, Jan 19, 2021 at 9:07 AM Zhang, Jie <zhangjie2@cn.fujitsu.com> wrote:
> >
> > Hi all
> >
> > After executing command [pg_dump -?], some help information is as follows.
> >
> > pg_dump -?
> > -----------------------------------------------------------------
> >   -N, --exclude-schema=PATTERN do NOT dump the specified schema(s)          ※
> >   -T, --exclude-table=PATTERN  do NOT dump the specified table(s)           ※
> >   -x, --no-privileges          do not dump privileges (grant/revoke)
> >   --exclude-table-data=PATTERN do NOT dump data for the specified table(s)  ※
> >   --no-comments                do not dump comments
> >   --no-publications            do not dump publications
> >   --no-security-labels         do not dump security label assignments
> >   --no-subscriptions           do not dump subscriptions
> >   --no-synchronized-snapshots  do not use synchronized snapshots in parallel jobs
> >   --no-tablespaces             do not dump tablespace assignments
> >   --no-unlogged-table-data     do not dump unlogged table data
> > --------------------------------------------------------------------
> >
> > I think it would be better to change [do NOT dump] to [do not dump].
> >
> > Here is a patch.
>
> +1. Looks like SQL keywords are mentioned in capital letters in both
> pg_dump and pg_dumpall cases, so changing "do NOT" to "do not" seems
> okay to me.
>
> Patch LGTM.

Also  "do NOT" is inconsistent with the other message where we are
saying "do not" so +1

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com