Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation[pgAdmin4] [Feature]

Hi Dave,

Please find attached rebased patch.

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Sun, Jan 8, 2017 at 4:07 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

Can you rebase this please? It no longer applies :-(

On Wednesday, December 28, 2016, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi Dave,

Here is updated (V4) patch.

Changes: 1] Now can enter both type of slashes ( / and \ ) and all will get replaced with the platform standard.

2] Added unicode support.

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Dec 19, 2016 at 5:16 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Fri, Dec 16, 2016 at 6:46 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch below for direct file navigation.
> I have covered all of above mentioned case.

Still not there I'm afraid:

- On Mac, if I type \Users\dpage, it changes it to /\Users\dpage and
then tells me it doesn't exist. Per the RM, either forward or back
slashes should be acceptable ("The path should accept either / or \ as
separators. Upon successful navigation to the path (after pressing
Return), the slashes should be replaced with the platform standard if
needed.")

- Unicode handling seems to be completely broken - see the attached screenshot.

I haven't tested on Windows yet, and only in Desktop mode on Mac.
Please test on Windows and Mac or Linux with both Python 2 and 3, in
both Server and Desktop modes to ensure that the behaviour meets the
requirements of the ticket with Unicode and non-Unicode paths and
files before resubmitting.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company