Re: patch for issue RM1260 [pgAdmin4]

Hi,

PFA updated patch for RM1260.

In addition to RM1260 issue I have added following changes in this patch.

1] datamodel.js: Added option check against undefined.

2] foreign key: fixed first empty option issue.

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 5:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Sure - I will do.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Thu, Jul 7, 2016 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:

Ashesh, can you review/commit please?

Thanks.

On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

By mistake I deleted a line which was not supposed to be deleted, and that line of code was initialization of select2.

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Harshal,

Can you please explain - what was missing in the last patch?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA updated patch for issue RM1260

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please ignore this patch as this has some minor issue. I'll sent updated one.

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA patch for issue RM1260.

Changes: Issue wasn't related to foreign table but was due the Select2 control. Now I have improved select2 control to handle null value in multi-select mode. Initial it was returning "null" instead it should return [] (empty array).

-- 

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company