Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

Hi Harshal 

I have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.

On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

It works, sorry for the noise.

On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Harshal, 

Can you please rebase the patch, it's not applied with the latest code.

On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:

Adding Akshay...

    Sure. 

On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:

Akshay, can you review/commit this please?

On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find attached patch to represent array data in datagrid with curly braces and

also allow user to save array with values like  <null>, <empty string>, '""' and "''"

-- 

Harshal Dhumal

Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246