Re: User management functionality patch [pgadmin4]

Hi Harshal,

Please find the review comments so far:

Issues:

1. The UI design doesn't look interactive, especially add new user button.

2. In requirements.txt, while adding new dependent library the name of library and version should be separate by '==' instead of '--'

3. Under File menu, "Users" menu item should not be visible for non-admin users. For now it is only disabled.

4. Change role of admin user to non-admin user, then navigate to File > Users. It doesn't show users in Dialog and Add user doesn't work. Instead it is better to reload the page. Please find attached screenshot.

5. The data grid content should fill the unnecessary gap above the footer.

6. The title of delete user confirmation dialog should be "Delete user ?", instead of "Delete User".

7. The Edit and Delete column shouldn't be sortable.

8. Columns 'creation time' & 'last modified' are missing.

9. Password should have validation of minimum number of characters.

Can be added into TODO list:

1. There is no way to search a user by name or email id.

2. Pagination should be there if there are large number of users.

3. There should be a way of notifying the user once its password is changed by any administrator.

4. We can add 'created by' column.

5. One administrator shouldn't have privilege to modify the details of other administrator.

This is the role of super admin.

Thanks

Surinder Kumar

On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA initial patch for User management functionality.

-- 

Harshal Dhumal

Software Engineer 

EenterpriseDB

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers