Re: Verbose output of pg_dump not show schema name

Поиск
Список
Период
Сортировка
От Fabrízio de Royes Mello
Тема Re: Verbose output of pg_dump not show schema name
Дата
Msg-id CAFcNs+rDbuCm7dxHhpGTnJe32mepVtmrJb90nVE_bRBB=UqZiA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Verbose output of pg_dump not show schema name  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: Verbose output of pg_dump not show schema name
Список pgsql-hackers
Дерево обсуждения

On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian <bruce@momjian.us> wrote:
>
> On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > The idea is that we only need quotes when there are odd characters in
> > > the identifier.  We do that right now in some places, though I can't
> > > find them in pg_dump.  I know psql does that, see quote_ident().
> >
> > I think our general style rule is that identifiers embedded in messages
> > are always double-quoted.  There's an exception for type names, but
> > not otherwise.  You're confusing the message case with printing SQL.
>
> OK.  I was unclear if a status _display_ was a message like an error
> message.
>

The attached patch fix missing double-quoted in "dumping contents of table.." message and add schema name to other messages:
- "reading indexes for table \"%s\".\"%s\"\n"
- "reading foreign key constraints for table \"%s\".\"%s\"\n"
- "reading triggers for table \"%s\".\"%s\"\n"
- "finding the columns and types of table \"%s\".\"%s\"\n"
- "finding default expressions of table \"%s\".\"%s\"\n"
- "finding check constraints for table \"%s\".\"%s\"\n"

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Вложения

В списке pgsql-hackers по дате отправления: